move Retry code to its own method for Hooking purposes#1
Open
vivianlonging wants to merge 1 commit intoCrackedP0t:masterfrom
Open
move Retry code to its own method for Hooking purposes#1vivianlonging wants to merge 1 commit intoCrackedP0t:masterfrom
vivianlonging wants to merge 1 commit intoCrackedP0t:masterfrom
Conversation
Author
|
I also spoke with an Everest dev who says it might make the most sense to make it a function inside level, which would resolve this conflict more efficiently with a different PR |
Owner
|
This seems totally reasonable - I'd be happy to merge this, if you remove the changes to the csproj. If you think it should be changed that's fine, but I think it should be in a different PR. |
Author
|
I'm going to wait a few days to try to get a response as to whether or not Everest will definitely make the Retry method a method inside Level because that would be a bigger help in general |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request just moves the code that makes the Player retry to its own method.
I'm trying to introduce a code mechanic that revolves around whether or not the end user retries, and I cannot realistically hook into the source function for Retrying, so I made this pull request in the hopes that this can resolve my problem, and it appears to currently