Skip to content

Conversation

@woojo230
Copy link
Collaborator

@woojo230 woojo230 commented Dec 20, 2025

#️⃣ Related Issue

e.g. Closes #issue-number

📝 Description

  • modularize chart gradients with a configuration array
  • chart componenet design update & update fillter logic
  • 🎨Design: fix chartInfo top value

📌 Notes

✅ Checklist

  • Have you selected the reviewers?
  • Have you assigned yourself?
  • Is the target branch correct?
  • Does this PR follow the project conventions?
  • Does the code run without errors locally?
  • Have unnecessary comments been removed?
  • Is the code style consistent?

📷 Screenshots (Optional)

💬 Review Requests (Optional)

e.g. I'm looking for a better name for method XXX. Any suggestions?

@woojo230 woojo230 requested a review from sheepyis December 20, 2025 16:47
@woojo230 woojo230 self-assigned this Dec 20, 2025
@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request December 20, 2025 16:47 Inactive
Copy link
Member

@sheepyis sheepyis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG

@@ -0,0 +1,28 @@
const GRADIENT_CONFIGS = [
{ id: 'colorSub1', color: '#8979FF' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the colors defined in theme.css!

const ChartGradients = () => {
return (
<defs>
{GRADIENT_CONFIGS.map((config) => (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate the List and Item components!

@sheepyis sheepyis merged commit 1a08455 into develop Dec 20, 2025
3 checks passed
@sheepyis sheepyis deleted the refactor/woojo230-chart#18 branch December 20, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants