Skip to content

Conversation

@sheepyis
Copy link
Member

#️⃣ Related Issue

e.g. Closes #14

📝 Description

  • Add filter component UI
  • Implement filter store for state management

📌 Notes

  • Installed clsx for conditional styling.
  • The ItemFilter UI appears to break depending on the device. Please take a look.

✅ Checklist

  • Have you selected the reviewers?
  • Have you assigned yourself?
  • Is the target branch correct?
  • Does this PR follow the project conventions?
  • Does the code run without errors locally?
  • Have unnecessary comments been removed?
  • Is the code style consistent?

📷 Screenshots (Optional)

스크린샷 2025-12-21 오전 12 28 32

💬 Review Requests (Optional)

e.g. I'm looking for a better name for method XXX. Any suggestions?

Add Filter Component UI
@sheepyis sheepyis requested a review from woojo230 December 20, 2025 15:36
@sheepyis sheepyis self-assigned this Dec 20, 2025
@sheepyis sheepyis added the ✨ feature 새로운 기능 개발 label Dec 20, 2025
@github-actions
Copy link

github-actions bot commented Dec 20, 2025

@github-actions github-actions bot temporarily deployed to pull request December 20, 2025 15:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 20, 2025 15:41 Inactive
Copy link
Collaborator

@woojo230 woojo230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

const ItemFilter = ({ item }: ItemFilterProps) => {
const { selectedFilter, setFilter } = useFilterStore();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use selector callbacks for useFilterStore to optimize performance

@sheepyis sheepyis merged commit fe3649a into develop Dec 20, 2025
3 checks passed
@sheepyis sheepyis deleted the design/sheepyis-filter#14 branch December 20, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ feature 새로운 기능 개발

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Feat: Add filter button UI

3 participants