Skip to content

Conversation

@woojo230
Copy link
Collaborator

@woojo230 woojo230 commented Dec 20, 2025

#️⃣ Related Issue

e.g. Closes #12

📝 Description

  • Add Banner component with stock data
  • Add update animations to Banner using Framer Motion

📌 Notes

✅ Checklist

  • Have you selected the reviewers?
  • Have you assigned yourself?
  • Is the target branch correct?
  • Does this PR follow the project conventions?
  • Does the code run without errors locally?
  • Have unnecessary comments been removed?
  • Is the code style consistent?

📷 Screenshots (Optional)

💬 Review Requests (Optional)

e.g. I'm looking for a better name for method XXX. Any suggestions?

@woojo230 woojo230 requested a review from sheepyis December 20, 2025 15:30
@woojo230 woojo230 self-assigned this Dec 20, 2025
@woojo230 woojo230 added the ✨ feature 새로운 기능 개발 label Dec 20, 2025
@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request December 20, 2025 15:37 Inactive
Copy link
Member

@sheepyis sheepyis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

<div className="flex flex-col">
<p className="text-[2.6rem] font-bold text-main">Emotional index</p>
<div className="flex flex-row gap-[0.8rem]">
{stocks.map((stock, index) => (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate the List and Item components. :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Denied

@woojo230 woojo230 merged commit 85e8d89 into develop Dec 20, 2025
3 checks passed
@woojo230 woojo230 deleted the feat/woojo230-banner#12 branch December 20, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ feature 새로운 기능 개발

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Feat: Add a header banner

3 participants