Skip to content

Conversation

@woojo230
Copy link
Collaborator

#️⃣ Related Issue

e.g. Closes #8

📝 Description

  • I developed chart components using the Recharts library and implemented filtering logic

📌 Notes

✅ Checklist

  • Have you selected the reviewers?
  • Have you assigned yourself?
  • Is the target branch correct?
  • Does this PR follow the project conventions?
  • Does the code run without errors locally?
  • Have unnecessary comments been removed?
  • Is the code style consistent?

📷 Screenshots (Optional)

💬 Review Requests (Optional)

e.g. I'm looking for a better name for method XXX. Any suggestions?

@woojo230 woojo230 requested a review from sheepyis December 20, 2025 13:21
@woojo230 woojo230 self-assigned this Dec 20, 2025
@woojo230 woojo230 added the ✨ feature 새로운 기능 개발 label Dec 20, 2025
@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request December 20, 2025 13:21 Inactive
<Area
type="monotone"
dataKey="subject2"
stroke="#ff7c7c"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the colors defined in theme.ts!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

function ChartSInfo() {
return (
<div className="absolute flex w-full justify-center items-center gap-6">
<div className="flex justify-center items-center gap-0.5">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks quite repetitive. It would be better to refactor it using map() method!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Denied. sorry

@woojo230 woojo230 merged commit f5fccf1 into develop Dec 20, 2025
3 checks passed
@woojo230 woojo230 deleted the feat/woojo230-chart#8 branch December 20, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ feature 새로운 기능 개발

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Feat: Add Chart component

3 participants