Data-driven planet colors and respecting the world border#53
Open
M-W-K wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Planets that sample biomes to determine their texture now load their coloring rules from planet data.
The sampled texture in Deep Space now respects the position and size of the world border.
Moving in and out of Deep Space now respects the position and size of the world border.
Why this change
More data-driven configuration is good. We cannot possibly hardcode all possible biomes added by other mods.
It has been a long-standing complaint that even small changes to position in orbit send you extremely far away in the overworld. Respecting the world border allows this to be resolved without sacrificing the ability to reach any accessible position in the dimension via orbit.