-
Notifications
You must be signed in to change notification settings - Fork 3
Pyproject.toml-based installation, updated dependencies, and automatic Docker builds #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @cailmdaley, looking good so far. 👏 I added a few comments on things you can look into. One general point to note is that we probably won't want/need any pinned dependencies in the pyproject.toml
as we can tag versions of the Docker image instead.
thank you for the helpful comments Sam. to your general point, wouldn't it be better to specify python dependencies in the |
…ocstrings for 2pcf and eb methods
I think this is ready to be merged pending review, I will do one more run through the whole script to make sure everything works. |
Co-authored-by: Martin Kilbinger <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hi @cailmdaley, my apologies for being so slow to finalise this review. I have run the following tests:
In summary, if the scope of this PR is simply to add a |
Thank you Sam! I really appreciate you taking the time to check this. It's good to hear that the Docker build works on another system and a plain pip installation almost works out of the box. Yes I think making things work for MacOS is beyond the scope of this PR. Making it usable more widely would be nice longer-term, but for now I think it's most important to get these changes merged so we can use them for the ongoing UNIONS cosmic shear analyses. I will go ahead and merge. |
The shapepipe and sp_validation packages have inconsistent version requirements, causing dependency versions to change when installing both packages in the same environment. This PR attempts to make the dependencies of the two packages consistent (and adds a few new dependencies).
While I was at it, I switched form the old setup.py installation method to the modern pyproject.toml approach.
I also plan to set up automatic GitHub builds of a docker container for the package, building on top of the container for the shapepipe package.