-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tiling issue in raster_tile.py #452
base: 0.5.0
Are you sure you want to change the base?
Conversation
Rounding off the profile['transform'] to 3 decimal places is leading to overwrite of some tiles while saving the chips.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that status checks are showing it's clear tests are not passing yet. This is strange, because they pass when I run them using make test
locally. I think we need to align our gh action testing with our local testing. @srmsoumya @rodrigoalmeida94 I'm off for the day but if either of you get a chance can you investigate why tests are not passing on gh actions but they are with make test
?
@rbavery I was able to reproduce the test errors locally. The array values are different for tiles in
Visually they look similar but array values are different. We are just changing the precision for file names, everything else remains the same.
|
@srmsoumya looking at your recent commit and just a heads up, using |
Description
Raster tiler is missing a few tiles while creating the chips. Rounding the
profile["transform"]
to 3 decimal places is creating the issue of chips overwrite, changing this to 6 decimal places fixes the issue.Type of change
Checklist:
If your PR does not fulfill all of the requirements in the checklist above, that's OK! Just prepend [WIP] to the PR title until they are all satisfied. If you need help, @-mention a maintainer and/or add the Status: Help Needed label.