-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move wasmvm/spec
and cosmwasm/SEMANTICS.md
here
#167
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ff6c07a
to
c329d7b
Compare
c329d7b
to
f36ded1
Compare
f36ded1
to
01be56a
Compare
Most of the |
01be56a
to
81a80e6
Compare
81a80e6
to
8a8d402
Compare
8a8d402
to
8d5d90f
Compare
8d5d90f
to
aae2896
Compare
aae2896
to
ef97851
Compare
ef97851
to
9802f58
Compare
9802f58
to
45a6837
Compare
45a6837
to
61c02d3
Compare
61c02d3
to
335fab2
Compare
6d688db
to
ebf3052
Compare
ebf3052
to
4822fea
Compare
4822fea
to
0d65983
Compare
3be12e5
to
0d5495f
Compare
0d5495f
to
83ce1e6
Compare
83ce1e6
to
93dcdb2
Compare
93dcdb2
to
496f6f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, only one more comment from me, then we can merge IMHO.
@@ -28,3 +28,79 @@ error, retry the operation, ignore it, etc. | |||
|
|||
The default value `ReplyOn::Success` means the caller is not ready to handle an error in the message | |||
execution and the entire transaction is reverted on error. | |||
|
|||
## Dispatching Submessages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this section should come before the "Preventing rollbacks" section above, since rollbacks only really make sense once you can use submessages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense - done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Let's get this merged.
Any relevant information from
wasmvm/spec
should be added to the main docs by this PR. The information from the filecosmwasm/SEMANTICS.md
should be updated and placed here as well. PRs related:spec
to cosmwasm documentation wasmvm#566 - spec removed from wasmvmMerging this PR solves this issue (and every sub-issue): CosmWasm/cosmwasm#1963