Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move wasmvm/spec and cosmwasm/SEMANTICS.md here #167

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

kulikthebird
Copy link
Contributor

@kulikthebird kulikthebird commented Oct 17, 2024

Any relevant information from wasmvm/spec should be added to the main docs by this PR. The information from the file cosmwasm/SEMANTICS.md should be updated and placed here as well. PRs related:

Merging this PR solves this issue (and every sub-issue): CosmWasm/cosmwasm#1963

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmwasm-docs ✅ Ready (Inspect) Visit Preview 2 resolved Jan 9, 2025 6:54pm

@kulikthebird
Copy link
Contributor Author

Most of the wasmvm/spec was outdated or already described in other places in this docs repository. Therefor the three files from wasmvm were omitted in this PR

@kulikthebird kulikthebird force-pushed the tkulik/wasmvm_docs_and_cw_semantics branch from 01be56a to 81a80e6 Compare November 13, 2024 12:34
@kulikthebird kulikthebird force-pushed the tkulik/wasmvm_docs_and_cw_semantics branch from 81a80e6 to 8a8d402 Compare November 13, 2024 12:43
@kulikthebird kulikthebird force-pushed the tkulik/wasmvm_docs_and_cw_semantics branch from 8a8d402 to 8d5d90f Compare November 14, 2024 14:23
@kulikthebird kulikthebird force-pushed the tkulik/wasmvm_docs_and_cw_semantics branch from 8d5d90f to aae2896 Compare November 14, 2024 14:48
@kulikthebird kulikthebird force-pushed the tkulik/wasmvm_docs_and_cw_semantics branch from aae2896 to ef97851 Compare November 14, 2024 14:58
@kulikthebird kulikthebird force-pushed the tkulik/wasmvm_docs_and_cw_semantics branch from ef97851 to 9802f58 Compare November 14, 2024 15:12
@kulikthebird kulikthebird force-pushed the tkulik/wasmvm_docs_and_cw_semantics branch from 9802f58 to 45a6837 Compare November 18, 2024 17:05
@kulikthebird kulikthebird force-pushed the tkulik/wasmvm_docs_and_cw_semantics branch from 45a6837 to 61c02d3 Compare December 6, 2024 12:04
@kulikthebird kulikthebird force-pushed the tkulik/wasmvm_docs_and_cw_semantics branch from 61c02d3 to 335fab2 Compare December 6, 2024 12:09
Copy link
Contributor

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, only one more comment from me, then we can merge IMHO.

@@ -28,3 +28,79 @@ error, retry the operation, ignore it, etc.

The default value `ReplyOn::Success` means the caller is not ready to handle an error in the message
execution and the entire transaction is reverted on error.

## Dispatching Submessages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section should come before the "Preventing rollbacks" section above, since rollbacks only really make sense once you can use submessages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense - done

Copy link
Contributor

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's get this merged.

@kulikthebird kulikthebird merged commit 637dce4 into main Jan 10, 2025
6 checks passed
@kulikthebird kulikthebird deleted the tkulik/wasmvm_docs_and_cw_semantics branch January 10, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants