Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing conversions between primitive and wrapped integer types #2348

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Add missing conversions between primitive and wrapped integer types #2348

merged 3 commits into from
Jan 23, 2025

Conversation

webmaster128
Copy link
Member

Closes #2268

chipshort
chipshort reviewed Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Much more readable with the macros

packages/std/src/math/uint128.rs Outdated Show resolved Hide resolved
chipshort
chipshort approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chipshort chipshort merged commit 589d242 into main Jan 23, 2025
39 checks passed
@chipshort chipshort deleted the uint-convert branch January 23, 2025 13:03
@webmaster128
Copy link
Member Author

@mergify backport release/2.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 29, 2025 •
edited
Loading

backport release/2.2

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jan 29, 2025
Merged
chipshort added a commit that referenced this pull request Jan 29, 2025
@chipshort
Merge pull request #2354 from CosmWasm/mergify/bp/release/2.2/pr-2348
4f0a953 
Add missing conversions between primitive and wrapped integer types (backport #2348 to 2.2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipshort chipshort chipshort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement From<Uint{64,128}> for u{64,128} and From<Int{64,128}> for i{64,128}
2 participants
@webmaster128 @chipshort