-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate abort
feature
#2337
Deprecate abort
feature
#2337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, I wish Rust had the ability to actually emit warnings instead of having to resort to these hacks..
Should we backport this and #2350 to the 2.2 branch such that we can remove it on main for 3.0? |
You mean publish a patch version with the deprecation and then remove it on main? I think that makes sense. |
Yeah, given that no 2.3 is planned I was wondering where the intermediate step goes. It would allow users to remove the feature during 2.2.x times and have one less thing to worry about when 3.0 is out. This change breaks almost no user since |
@Mergifyio backport release/2.2 |
✅ Backports have been created
|
Deprecate `abort` feature (backport #2337)
closes #2243
Unfortunately there is no native way to cause a compiler warning, so this is a bit of a hack.