Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate abort feature #2337

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Deprecate abort feature #2337

merged 4 commits into from
Jan 13, 2025

Conversation

chipshort
Copy link
Collaborator

closes #2243

Unfortunately there is no native way to cause a compiler warning, so this is a bit of a hack.

Copy link
Member

@aumetra aumetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, I wish Rust had the ability to actually emit warnings instead of having to resort to these hacks..

@chipshort chipshort merged commit edc73fd into main Jan 13, 2025
9 of 38 checks passed
@chipshort chipshort deleted the co/deprecate-abort branch January 13, 2025 12:48
@webmaster128
Copy link
Member

Should we backport this and #2350 to the 2.2 branch such that we can remove it on main for 3.0?

@chipshort
Copy link
Collaborator Author

Should we backport this and #2350 to the 2.2 branch such that we can remove it on main for 3.0?

You mean publish a patch version with the deprecation and then remove it on main? I think that makes sense.

@webmaster128
Copy link
Member

Yeah, given that no 2.3 is planned I was wondering where the intermediate step goes. It would allow users to remove the feature during 2.2.x times and have one less thing to worry about when 3.0 is out.

This change breaks almost no user since abort is not explicit for most users but just a standard feature from cosmwasm-std. The abort import is available at least since 1.0.0.

@chipshort
Copy link
Collaborator Author

@Mergifyio backport release/2.2

Copy link
Contributor

mergify bot commented Feb 19, 2025

backport release/2.2

✅ Backports have been created

chipshort added a commit that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate abort feature
3 participants