Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the cranelift features #2260

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Remove the cranelift features #2260

merged 4 commits into from
Sep 24, 2024

Conversation

aumetra
Copy link
Member

@aumetra aumetra commented Sep 20, 2024

Remove the cranelift features since they aren't really needed at all, and (according to some unscientific tests) they add quite some time on the runs of our coverage CI run.

Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add a changelog entry?

@aumetra aumetra force-pushed the aw/remove-cranelift branch from 1031a24 to 1025b25 Compare September 23, 2024 14:47
@aumetra
Copy link
Member Author

aumetra commented Sep 23, 2024

Added!

@aumetra aumetra requested a review from chipshort September 23, 2024 14:49
@aumetra aumetra force-pushed the aw/remove-cranelift branch from 326d541 to dc0cd62 Compare September 24, 2024 11:59
@aumetra aumetra merged commit 3a8b7d7 into main Sep 24, 2024
36 of 37 checks passed
@aumetra aumetra deleted the aw/remove-cranelift branch September 24, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants