Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go-gen improvements #2027

Merged
merged 5 commits into from
Feb 20, 2024
Merged

Go-gen improvements #2027

merged 5 commits into from
Feb 20, 2024

Conversation

chipshort
Copy link
Collaborator

@chipshort chipshort commented Feb 15, 2024

  • Adds special handling for ReplyOn and VoteOption, as those have corresponding custom types in wasmvm.
  • Generates the new Array[T] type added in wasmvm. This is now always used for Vec<T>. Option<Vec<T>> continues to be generated as *[]T.
  • Fields with a #[serde(default)] annotation now add omitempty. This is necessary because serde fails if these are passed as null. Only missing entries are accepted and replaced with the default value.

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff

@chipshort chipshort merged commit bd6b54d into main Feb 20, 2024
29 checks passed
@chipshort chipshort deleted the go-gen-fixes branch February 20, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants