Add std feature
#1971
Merged
Add std feature
#1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipshort
commented
Dec 14, 2023
webmaster128
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regarding #1484
This adds the
stdfeature as a default and replaces the most obvious usages ofstd.It does not provide full
no_stdsupport.Some notes for anyone tackling full
no_stdsupport in the future:The next big problem is
thiserror. It should be possible to only enable it whenstdis enabled and provide alternative Display / Debug implementations otherwise.The
JsonSchemaderive macro also would need to be patched to use core / alloc instead of std, but that should be straightforward.Apart from that, some of our dependencies are likely not
no_std, so changes might be needed there.