Skip to content

fix: ScreenshotUtility.cs WebGL compilation #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SabadashDenis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ScreenshotUtility.cs WebGL compilation #578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...nity/Runtime/Helpers/ScreenshotUtility.cs → ...Unity/Editor/Helpers/ScreenshotUtility.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
using System.Linq;
using UnityEngine;

namespace MCPForUnity.Runtime.Helpers
namespace MCPForUnity.Editor.Helpers
//The reason for having another Runtime Utilities in additional to Editor Utilities is to avoid Editor-only dependencies in this runtime code.
Comment on lines +6 to 7
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Stale comment references Runtime context.

The namespace update on line 6 is correct. However, line 7's comment still refers to "Runtime Utilities" and "runtime code," which is now misleading since this file has been relocated to the Editor assembly.

📝 Suggested fix 
 namespace MCPForUnity.Editor.Helpers
-//The reason for having another Runtime Utilities in additional to Editor Utilities is to avoid Editor-only dependencies in this runtime code.
 {

Or update the comment to reflect the new Editor-only purpose if documentation is still desired.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
namespace MCPForUnity.Editor.Helpers
//The reason for having another Runtime Utilities in additional to Editor Utilities is to avoid Editor-only dependencies in this runtime code.
namespace MCPForUnity.Editor.Helpers
{
🤖 Prompt for AI Agents 
In `@MCPForUnity/Editor/Helpers/ScreenshotUtility.cs` around lines 6 - 7, The
inline comment following the namespace MCPForUnity.Editor.Helpers is
stale—remove or rewrite it to reflect that this file (ScreenshotUtility) now
lives in the Editor assembly and is Editor-only; update the comment text to
mention "Editor-only utilities" or delete the comment entirely so it no longer
references "Runtime Utilities" or "runtime code", and ensure the change is
applied in the ScreenshotUtility.cs header near the namespace declaration.

{
public readonly struct ScreenshotCaptureResult
Expand Down
0 ...Runtime/Helpers/ScreenshotUtility.cs.meta → .../Editor/Helpers/ScreenshotUtility.cs.meta
View file
Open in desktop
File renamed without changes.
1 change: 0 additions & 1 deletion MCPForUnity/Editor/Tools/ManageScene.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
using System.IO;
using System.Linq;
using MCPForUnity.Editor.Helpers; // For Response class
using MCPForUnity.Runtime.Helpers; // For ScreenshotUtility
using Newtonsoft.Json.Linq;
using UnityEditor;
using UnityEditor.SceneManagement;
Expand Down
8 changes: 0 additions & 8 deletions MCPForUnity/Runtime/Helpers.meta
View file
Open in desktop

This file was deleted.