Skip to content

fix: enforce HTTPS in ResilientHttpClient to prevent cleartext credential transmission (CWE-319) #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quangtran88 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: enforce HTTPS in ResilientHttpClient to prevent cleartext credential transmission (CWE-319) #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions src/conway/http-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ import { DEFAULT_HTTP_CLIENT_CONFIG } from "../types.js";

export class CircuitOpenError extends Error {
constructor(public readonly resetAt: number) {
super(
`Circuit breaker is open until ${new Date(resetAt).toISOString()}`,
);
super(`Circuit breaker is open until ${new Date(resetAt).toISOString()}`);
this.name = "CircuitOpenError";
}
}
Expand All @@ -36,6 +34,19 @@ export class ResilientHttpClient {
retries?: number;
},
): Promise<Response> {
// Enforce HTTPS to prevent cleartext transmission of credentials.
// Allow localhost/127.0.0.1 for local development only.
const parsed = new URL(url);
if (
parsed.protocol !== "https:" &&
parsed.hostname !== "localhost" &&
parsed.hostname !== "127.0.0.1"
) {
throw new Error(
`Refusing to send request over insecure protocol: ${parsed.protocol} (use HTTPS)`,
);
}

if (this.isCircuitOpen()) {
throw new CircuitOpenError(this.circuitOpenUntil);
}
Expand Down Expand Up @@ -67,7 +78,8 @@ export class ResilientHttpClient {
if (this.config.retryableStatuses.includes(response.status)) {
this.consecutiveFailures++;
if (this.consecutiveFailures >= this.config.circuitBreakerThreshold) {
this.circuitOpenUntil = Date.now() + this.config.circuitBreakerResetMs;
this.circuitOpenUntil =
Date.now() + this.config.circuitBreakerResetMs;
}
if (attempt < maxRetries) {
await this.backoff(attempt);
Expand All @@ -82,9 +94,7 @@ export class ResilientHttpClient {
} catch (error) {
clearTimeout(timer);
this.consecutiveFailures++;
if (
this.consecutiveFailures >= this.config.circuitBreakerThreshold
) {
if (this.consecutiveFailures >= this.config.circuitBreakerThreshold) {
this.circuitOpenUntil =
Date.now() + this.config.circuitBreakerResetMs;
}
Expand All @@ -98,9 +108,7 @@ export class ResilientHttpClient {

private async backoff(attempt: number): Promise<void> {
const delay = Math.min(
this.config.backoffBase *
Math.pow(2, attempt) *
(0.5 + Math.random()),
this.config.backoffBase * Math.pow(2, attempt) * (0.5 + Math.random()),
this.config.backoffMax,
);
await new Promise((resolve) => setTimeout(resolve, delay));
Expand Down