ggg#111
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough아바타 선택/생성 로직을 조정하고, 데일리 질문 응답 흐름을 ID 기반 조회 및 정수형 답변 매핑으로 변경했습니다. 컨트롤러에서 특정 아바타 마스터(ID 9999)를 제외하고, 서비스에서 마스터 조회 시 오프셋(+2)을 적용했습니다. 데일리 질문은 DTO 필드 변경, 서비스의 의존성 추가, ID 기반 질문 조회, 정수→enum 매핑 세터 도입이 포함됩니다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant C as Client
participant AC as AvatarController
participant AS as AvatarService
participant AMR as AvatarMasterRepository
rect rgb(245,248,255)
note over AC: 선택 가능한 아바타 목록 조회
C->>AC: GET /avatars/selectable
AC->>AS: getSelectableAvatarMasters()
AS-->>AC: List<AvatarMaster>
AC->>AC: ID 9999 필터링
AC-->>C: DTO List
end
rect rgb(245,255,245)
note over AC,AS: 아바타 생성(마스터 지정)
C->>AC: POST /avatars { masterId }
AC->>AS: createAvatar(masterId)
AS->>AMR: findById(masterId + 2)
AMR-->>AS: AvatarMaster | NOT_FOUND
AS-->>AC: Avatar
AC-->>C: Response
end
sequenceDiagram
autonumber
participant C as Client
participant DAS as DailyQuestionAnswerService
participant DQS as DailyQuestionService
participant DAR as DailyQuestionAnswerRepository
rect rgb(255,248,240)
note over C,DAS: 데일리 질문 응답 제출
C->>DAS: submit({ questionId: Long, answer: Integer })
DAS->>DAR: existsByUserAndAnsweredDate(user, today)
DAR-->>DAS: boolean
alt not exists
DAS->>DQS: getQuestionById(questionId)
DQS-->>DAS: String question
DAS->>DAS: build DailyQuestionAnswer(question)
DAS->>DAS: setAnswer(Integer)로 매핑(1/2/other)
DAS->>DAR: save(DailyQuestionAnswer)
DAR-->>DAS: saved
else exists
DAS-->>C: already answered
end
DAS-->>C: result
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (6)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This was referenced Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ㅎㅎㅎ
Summary by CodeRabbit
New Features
Bug Fixes