Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the SNAP does not auto update if the version is outdate in wallet UI #518

Open
wants to merge 2 commits into
base: chore/split-metamask-min-version-modal
Choose a base branch
from

Conversation

stanleyyconsensys
Copy link
Collaborator

This PR is to add a fix for a case that the SNAP does not auto update if the version is outdate in wallet UI

if the SNAP version is outdate , the wallet UI will trigger a reconnect workflow to update the SNAP

Changes:

  • Update the logic to detect the SNAP version is outdate or not
  • Does not show an re-install modal when snap is outdate, instead add reconnect workflow

Requirements:

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner February 21, 2025 07:14
@stanleyyconsensys stanleyyconsensys requested review from Julink-eth and jonesho and removed request for a team February 21, 2025 07:15
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
25.8% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant