add properties to key creation request#604
Open
dthuering wants to merge 1 commit intoConsensys:mainfrom
Open
Conversation
allow per key type setting for HSM backed storage in Azure
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow per key type setting for HSM-backed storage in Azure
PR description
To support HSM-backed keys in Azure Key Vault, the API payload and service request were extended in a backwards-compatible way to support additional, optional properties. The AKV store supports the
AZURE_KEY_VAULT_TYPEproperty with a value ofEC-HSM. When these are set, the key will be backed by HSM in AKV.Fixed Issue(s)
fixes #579
Changelog
Added a properties map to the Key Creation API endpoint and service attributes.
AKV store supports the
AZURE_KEY_VAULT_TYPEkey andEC-HSMvalue. That will enable HSM-backed keys.I thought about the changelog and included a changelog update if required.