[61] Implement Proposer selector #66
Conversation
| val genesisBlockNumber: ULong, | ||
| ) | ||
|
|
||
| override fun getProposerForBlock(header: BeaconBlockHeader): SafeFuture<Validator> { |
There was a problem hiding this comment.
Can't use this function from Qbft as we don't have a header where this is called. We need a function that takes a ConsensusRoundIdentifier. This interface will need to be implemented for Qbft https://github.com/hyperledger/besu/blob/main/consensus/common/src/main/java/org/hyperledger/besu/consensus/common/bft/blockcreation/ProposerSelector.java. I've extracted the interface from the helper class in Besu as we need that when we create the MessageValidatorFactory in qbft. It will be in the next release of Besu likely next week.
There was a problem hiding this comment.
I just updated it
gauravahuja
force-pushed
the
gauravahuja/61-proposer-selector
branch
from
1cb4921 to
b26f62d
Compare
gauravahuja
changed the base branch from
main
to
gauravahuja/60-qbft-block-validator
| prevProposer = result | ||
| returnedValidators.add(result) | ||
| } | ||
| assertThat(returnedValidators).isEqualTo(validators) |
There was a problem hiding this comment.
My understanding is that thanks to changeEachBlock out of totalValidators calls with consecutive block number we're getting 5 different validators. But I'm not sure if we're just lucky that the order of returnedValidators matches validators or it's the required property of ProposerSelectorImpl.
I think that order enforcement makes this test more brittle than necessary.
| fun `select proposer for next block`() { | ||
| val config = | ||
| ProposerSelectorImpl.Config( | ||
| changeEachBlock = true, |
There was a problem hiding this comment.
Do we need a test for changeEachBlock = false?
#61