Feat/advanced create2 testing #1922
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empty bytecode depl
amkCha
force-pushed
the
feat/advanced-create2-testing
branch
from
ebd26fc to
3d8d8de
Compare
amkCha
commented
Mar 25, 2025
| @@ -34,7 +34,7 @@ public static class ToyMultiTransactionBuilder { | |||
| * @return an instance of {@link List<Transaction>} | |||
| */ | |||
| public List<Transaction> build( | |||
| ToyTransactionBuilder[] toyTxBuilders, ToyAccount senderAccount) { | |||
| List<ToyTransactionBuilder> toyTxBuilders, ToyAccount senderAccount) { | |||
There was a problem hiding this comment.
Changed the type from array to list for the builder parameters when creating multiple transactions for the same account, for it to be easier to add builders during testing
amkCha
commented
Mar 25, 2025
| transactionBuilderLeadingDelegateCallerToCreateAnAccount, | ||
| transactionBuilderLeadingDelegateCallerToSelfDestruct, | ||
| transactionBuilderDeployingDelegateCallerAgain, | ||
| transactionBuilderLeadingDelegateCallerToAttemptCreateAgainThusRaisingFailureConditionF); |
There was a problem hiding this comment.
See comment for changing the method's signature in ToyMultiTransaction
amkCha
commented
Mar 25, 2025
| @@ -61,7 +61,7 @@ void testBlockwiseDeplNo() { | |||
| // Block 1 | |||
| .addBlock( | |||
| List.of( | |||
| tc.deployWithCreate2( | |||
| tc.deployWithCreate2_withRevertTrigger( | |||
There was a problem hiding this comment.
Keep TestingBase as it was for deployWithCreate2 and create new function to have it revertable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This suite aims at testing advanced CREATE2 scenarii using smart contracts.
It tests 5 deployment scenarii with the same init code through a smart contract piloting the deployment.
SmartContractTestValidatoris a generic TransactionProcessingValidator to validate log presence and data produced by the tests.Test coverage :
CustomCreate2 is the smart contract used to pilot the deployment of a complex initCodeC
CustomCreate2 stores an initCodeC and a salt used for subsequent deployments
CustomCreate2 has different create2 methods to have deployment scenarii within the same transaction
CustomCreate2 can CALL/STATICCALL itself and contractC
initCodeC can be piloted by CustomCreate2 via the value passed in the transaction
value 1 Wei enables a storage modification in ContractC
value 2 Wei calls CustomCreate2 back to trigger an immediate redeployment of ContractC
value 3 Wei triggers a self-destruct of ContractC
value 4 Wei triggers a revert on demand
ContractC can modify storage, revert on demand, self-destruct on demand, and call back
CustomCreate2 to trigger a redeployment of ContractC
SCENARIO 1 - Deploy ContractC through CustomCreate2, modify storage, self-destruct ContractC
SCENARIO 2 - Deploy ContractC and attempt redeployment after in same transaction
SCENARIO 3 - Deploy ContractC and the deployment attempts redeployment, empty bytecode is deployed, call ContractC to modify storage, revert on demand
SCENARIO 4 - Attempt ContractC deployment with a staticCall
SCENARIO 5 - Four ContractC deployment attempts : (1) with max value, (2) acceptable value, (3) max value and (4) acceptable value