Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] L1 contracts bump to solidity 0.8.28 #656

Merged
merged 10 commits into from
Feb 6, 2025
Merged

Conversation

kyzooghost
Copy link
Contributor

@kyzooghost kyzooghost commented Feb 5, 2025

This PR implements issue(s) #619

Also bump versions for following dependencies

  • hardhat
  • solhint
  • @openzeppelin/upgrades-core

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@kyzooghost kyzooghost requested a review from a team as a code owner February 5, 2025 13:00
@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e February 5, 2025 13:01 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.47%. Comparing base (4d85082) to head (8ca51fc).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #656      +/-   ##
============================================
+ Coverage     68.46%   68.47%   +0.01%     
+ Complexity     1185     1183       -2     
============================================
  Files           323      323              
  Lines         13130    13106      -24     
  Branches       1318     1318              
============================================
- Hits           8989     8974      -15     
+ Misses         3590     3580      -10     
- Partials        551      552       +1     
Flag Coverage Δ *Carryforward flag
hardhat 98.52% <ø> (ø)
kotlin 66.12% <ø> (+<0.01%) ⬆️ Carriedforward from c5f79d8

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
contracts/src/governance/TimeLock.sol 100.00% <ø> (ø)
contracts/src/recovery/RecoverFunds.sol 100.00% <ø> (ø)
contracts/src/rollup/LineaRollup.sol 98.03% <ø> (ø)
contracts/src/verifiers/PlonkVerifierDev.sol 0.00% <ø> (ø)
.../src/verifiers/PlonkVerifierForDataAggregation.sol 0.00% <ø> (ø)
...fiers/PlonkVerifierForMultiTypeDataAggregation.sol 0.00% <ø> (ø)
...ntracts/src/verifiers/PlonkVerifierSepoliaFull.sol 100.00% <ø> (ø)

... and 9 files with indirect coverage changes

@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e February 6, 2025 08:06 — with GitHub Actions Inactive
@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e February 6, 2025 08:29 — with GitHub Actions Inactive
thedarkjester
thedarkjester previously approved these changes Feb 6, 2025
@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e February 6, 2025 11:36 — with GitHub Actions Inactive
@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e February 6, 2025 12:15 — with GitHub Actions Inactive
@kyzooghost kyzooghost merged commit aa64956 into main Feb 6, 2025
24 of 25 checks passed
@kyzooghost kyzooghost deleted the feat/solidity-8.28 branch February 6, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants