Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initialize public committed #1317

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Nov 16, 2024

Description

When using a fixed verification key in Groth16 recursive prover, we do not initialize the public committed variables. This leads to a recursion error when using a fixed key.

See #1306 (comment)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

The test case in the discussion

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added the bug Something isn't working label Nov 16, 2024
@ivokub ivokub added this to the v0.11.N milestone Nov 16, 2024
@ivokub ivokub requested review from gbotrel and Tabaie November 16, 2024 15:15
@ivokub ivokub self-assigned this Nov 16, 2024
@ivokub ivokub merged commit 7512178 into master Nov 16, 2024
5 checks passed
@ivokub ivokub deleted the fix/groth16-recursive-fixed-public-commit branch November 16, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants