-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Add Icicle GPU-Accelleration to Plonk Prover behind build tag #1051
Draft
bigsky77
wants to merge
60
commits into
Consensys:master
Choose a base branch
from
ingonyama-zk:feat/plonk
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th BN254. Full replacement of CPU prove with GPU prove can be used with the build tag 'gpu'.
…or NTT and MSM. Add GPU memory cleanup using cudaFree Add GPU version of marshal
Update generation to include build tags
…erations Update iciclegnark dependency to v0.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds experimental support for Icicle GPU acceleration library for Plonk backend and the BN254 curve.
Type of change
[X] New feature (non-breaking change which adds functionality)
How has this been tested?
[X] Using the circuits in
gnark/examples/plonk/main.go
gnark
rungo run examples/plonk/main.go
[X] Using Ingonyama's fork of Succinct Lab's Gnark-Plonky2-Verifier
Gnark-Plonky2-Verifier
rungo run benchmarks.go --icicle
How has this been benchmarked?
Benchmarks ran on Gnark-Plonky2-Verifier using AWS: g5.8xlarge A10g 32 core 128GB.
Benchmarks can be seen here.
Note
These benchmarks are not final. We are still updating our Go Cuda bindings which will provide a significant speed-up to the NTT. Also note our Compute Quotient Polynomial is actively being refined to increase speed. The current implementation is ~20s slower than the ideal implementation due to the need to run CUDA processes synchronously. This will be updated when solved.
Dependencies
This merge requests depends on modifications to the following two repositories.
Checklist:
golangci-lint
does not output errors locally