This repository was archived by the owner on Feb 26, 2024. It is now read-only.
duplicate methods equal/notEqual for uint8-uint248#969
Closed
wjmelements wants to merge 783 commits intoConsenSys-archive:developfrom
Closed
duplicate methods equal/notEqual for uint8-uint248#969wjmelements wants to merge 783 commits intoConsenSys-archive:developfrom
wjmelements wants to merge 783 commits intoConsenSys-archive:developfrom
Conversation
but removing dependency on bluebird.
unless we delete the `require` cache. See here: mochajs/mocha#995 Fixes ConsenSys-archive#325
change in solidity testing. This commit upgrades all dependencies that depend on the new version of truffle-contract as well as fixes the result of the breaking change.
…e local node, which is much faster. This is a stop gap until we/Infura can figure out why IPFS requests are so slow.
…fore-exec Add `truffle exec` test
…s-fix Add original-fs to list of nils
…test Stop testing error message in EthPM test
…cha-v4 Upgrade mocha to 4.1.0
Upgrade solc to 0.4.24
|
looks good, but could you add a test for one of the cases |
Author
|
I need to make this change in truffle-core instead. |
Author
Author
|
Looks like the truffle-core repo was merged into this one. Reopening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if I try to compare two
uint248with truffle's Assert.equal, I get a syntax error. To avoid casting, I added support foruint8throughuint248to theequalandnotEqualmethods in Assert.sol.