This repository was archived by the owner on Jun 14, 2018. It is now read-only.
Copy gasPrice and gasLimit with dry-run#81
Open
f10et wants to merge 3 commits intoConsenSys-archive:developfrom
f10et:fix/680_gasprice_ignored
Open
Copy gasPrice and gasLimit with dry-run#81f10et wants to merge 3 commits intoConsenSys-archive:developfrom f10et:fix/680_gasprice_ignored
f10et wants to merge 3 commits intoConsenSys-archive:developfrom
f10et:fix/680_gasprice_ignored
Conversation
1 task
gnidan
reviewed
Feb 2, 2018
Contributor
gnidan
left a comment
gnidan
left a comment
There was a problem hiding this comment.
Thanks for catching this! Marking this to get merged and deployed in the next release.
lib/environment.js
Outdated
| provider: TestRPC.provider({ | ||
| fork: config.provider, | ||
| unlocked_accounts: accounts | ||
| unlocked_accounts: accounts, |
Contributor
There was a problem hiding this comment.
I'm kind of paranoid about trailing commas in JS, mind removing this?
Contributor
|
Oh I was missing some context - will circle back with others on the team and make sure this isn't waiting for another reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue ConsenSys-archive/truffle#680
The problem was the gasPrice and gasLimit of the network being ignored when running a dry-run, as they were not copied over in the forked network