This repository was archived by the owner on Jun 14, 2018. It is now read-only.
merge config in develop#80
Open
miyao-gmo wants to merge 1 commit intoConsenSys-archive:developfrom
miyao-gmo:feature/use_develop_config
Open
merge config in develop#80miyao-gmo wants to merge 1 commit intoConsenSys-archive:developfrom miyao-gmo:feature/use_develop_config
miyao-gmo wants to merge 1 commit intoConsenSys-archive:developfrom
miyao-gmo:feature/use_develop_config
Conversation
Author
gnidan
suggested changes
Feb 2, 2018
Contributor
gnidan
left a comment
gnidan
left a comment
There was a problem hiding this comment.
Just requesting changes for the spacing.
Besides that, could you please verify that this works as expected in the context of truffle test?
Thanks for the contribution! Will look to get this into the next release.
lib/environment.js
Outdated
| network_id: testrpcOptions.network_id, | ||
| provider: function() { | ||
| return new Web3.providers.HttpProvider(url); | ||
| } |
Contributor
There was a problem hiding this comment.
(Please conform to 2-space indents :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.