This repository was archived by the owner on Jun 14, 2018. It is now read-only.
Run test command if --tests flag is specified on watch#5
Open
p14n wants to merge 2 commits intoConsenSys-archive:masterfrom
Open
Run test command if --tests flag is specified on watch#5p14n wants to merge 2 commits intoConsenSys-archive:masterfrom
p14n wants to merge 2 commits intoConsenSys-archive:masterfrom
Conversation
Author
|
@tcoulter I'd like to start using this - any comments? Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --tests flag to watch. In issue 269 people were expecting --tests to run tests after a rebuild. I've added this. Note it diverts to the test task rather than rebuilding then passing to tests (where we would have to tell it not to rebuild), so that's up for discussion.
Also re-enabled ipfs server cleanup on test run (tests always failing until I did this).