Skip to content

Conversation

@ConnorStoneAstro
Copy link
Owner

No description provided.

@ConnorStoneAstro ConnorStoneAstro requested a review from Copilot June 6, 2025 22:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the coverage test to compute a two-tailed p-value rather than the previous one-tailed version.

  • Introduces a two_tailed_p function in utils.py that performs density‐based two‐tailed p-value calculation.
  • Updates pted_coverage_test in pted.py to use the new two_tailed_p function and adjusts behavior for the single-simulation case.
  • Adjusts test expectations and documentation in tests.py and README.md to align with the new two-tailed strategy.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/pted/utils.py Added two_tailed_p function for computing two-tailed p-values.
src/pted/pted.py Updated p-value aggregation to use two_tailed_p for combined tests.
src/pted/tests.py Modified test assertions to match new two-tailed p-value behavior.
README.md Updated documentation to describe the two-tailed coverage test.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a92fa33) to head (ca943b9).

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          190       212   +22     
=========================================
+ Hits           190       212   +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ConnorStoneAstro ConnorStoneAstro merged commit 6641406 into main Jun 7, 2025
12 checks passed
@ConnorStoneAstro ConnorStoneAstro deleted the grumpycoverage branch June 7, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants