-
Notifications
You must be signed in to change notification settings - Fork 34
yeet gulp from build system (involves lots of chaos) #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work, this looks great.
| Flask-pyoidc~=3.14.3 | ||
| Flask-SQLAlchemy~=3.1.1 | ||
| gunicorn~=22.0.0 | ||
| gunicorn~=20.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need to downgrade gunicorn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was just when I removed the dependabot updates (no real reason)
| @import 'sweet-alert-animations'; | ||
| @import './node_modules/bootstrap-sass/assets/stylesheets/bootstrap/mixins/forms'; | ||
| @import 'ball-fall'; | ||
| // @import 'ball-fall'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the effect of removing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh I couldn't figure out what this imported I'll look again before I'm done
Removed gulp from the build system for the frontend. I'd like to add back in the linting for frontend that happened but also that wasn't really working so it's not a regression either.
Also I'm sorry some of it is insane trying to update the build system with 8-9 year old dependencies in the project isn't fun (soon tm)