Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds compatibility to isaac glm PR #3498

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Adds compatibility to isaac glm PR #3498

merged 1 commit into from
Mar 9, 2021

Conversation

FelixTUD
Copy link
Contributor

@FelixTUD FelixTUD commented Jan 25, 2021 •
edited by psychocoderHPC
Loading

Adds compatibility to isaac glm PR with changed interface and isaac types
https://github.com/ComputationalRadiationPhysics/isaac/pull/130

[psychocoder edited] CI do not need to be updated, this PR is compatible with ISAAC 1.5.2

@sbastrakov
Copy link
Member

@FelixTUD there is an issue with formatting. Please follow these instructions to reformat, or #3464 if this gets complicated

@sbastrakov sbastrakov added the component: plugin in PIConGPU plugin label Jan 25, 2021
@FelixTUD
Copy link
Contributor Author

@sbastrakov the formatting is updated now

@psychocoderHPC
Copy link
Member

Are the changes compatible to the last isaac release? The CI is checking the dev branch of ISAAC which is equal to the last release.

@FelixTUD
Copy link
Contributor Author

No, the isaac interface changes with the isaac pull request
ComputationalRadiationPhysics/isaac#130
this is just the fix for it, that picongpu can use it againt, after the isaac pull request is merged

@psychocoderHPC psychocoderHPC marked this pull request as draft January 26, 2021 15:34
@psychocoderHPC
Copy link
Member

psychocoderHPC commented Jan 26, 2021 •
edited
Loading

I set this PR to draft, we need to update the CI container to have the new ISAAC version in our test and we need to check by hand that the new ISAAC version is used. The reason for the manual test is that we are not able to enforce searching for ISAAC or other optional dependencies.

@psychocoderHPC psychocoderHPC mentioned this pull request Feb 9, 2021
Open
@FelixTUD FelixTUD marked this pull request as ready for review March 9, 2021 10:57
@FelixTUD FelixTUD changed the title Adds compatibility to latest isaac PR Adds compatibility to isaac glm PR Mar 9, 2021
@psychocoderHPC psychocoderHPC self-requested a review March 9, 2021 13:51
@psychocoderHPC psychocoderHPC merged commit 6fe2cd2 into ComputationalRadiationPhysics:dev Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychocoderHPC psychocoderHPC psychocoderHPC approved these changes

Assignees
No one assigned
Labels
component: plugin in PIConGPU plugin
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@FelixTUD @sbastrakov @psychocoderHPC