Refactor logging & prints to use regular Python loggers #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated logging chnages for second review feedback updated and removed unnecessary stuff Remove functional changes
|
Hi @michaelosthege, thank you for your and @rapith777's contribution. |
|
Hi @cpr-bar, thanks! In the meantime we are working from our fork. I will try to open separate PRs for any bugfixes. Shall I also create a PR to add GitHub Actions to run a pre-commit and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @cpr-bar,
we are starting to use this library to interface with our SCARA, and would like to start contributing bugfixes.
With this PR we would like to propose using the Python logging framework through named loggers, because it makes it easier to filter log events.
We also replaced
prints in the examples by log messages such that we get timestamps.Credits to the code changes go to @rapith777 who just began his thesis project with us.