fix: Update compatibility with latest ComfyUI versions#5
Open
huchukato wants to merge 2 commits intoComfyAssets:mainfrom
Open
fix: Update compatibility with latest ComfyUI versions#5huchukato wants to merge 2 commits intoComfyAssets:mainfrom
huchukato wants to merge 2 commits intoComfyAssets:mainfrom
Conversation
- Fix import paths for new ComfyUI structure - Replace deprecated ctx.roundRect() with compatible implementation - Remove duplicate dimension_selectors.js to prevent conflicts - Optimize event handling with MutationObserver and requestAnimationFrame - Improve cleanup and resource management - Add compatibility documentation Resolves JavaScript errors in newer ComfyUI versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates ComfyUI-Selectors to be compatible with the latest ComfyUI versions, fixing JavaScript console errors that occurred after a year of no updates.
Issues Fixed
ctx.roundRect()with compatible Canvas API implementationMutationObserverandrequestAnimationFrameChanges Made
../../scripts/app.jsto../../../scripts/app.jsctx.roundRect()witharcTo()implementationsetTimeoutwithrequestAnimationFramefor better performanceMutationObserverfor efficient value monitoringTesting
comfyassets/categoryCompatibility
Breaking Changes
None - this is a compatibility fix only.
Additional
Added COMPATIBILITY_UPDATE.md with detailed documentation of all changes.