Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Remove duplicate build CI task #892

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Feb 12, 2025

  • Windows build is also performed in the "integration" test workflow
  • Adds PR/push triggers to Mac build workflow
  • Fixes husky path ignore missing leading full stop

┆Issue is synchronized with this Notion page by Unito

- Windows build is also performed in the "integration" test workflow
- Adds PR/push triggers to Mac build workflow
- Fixes husky path ignore missing leading full stop
@webfiltered webfiltered requested a review from a team as a code owner February 12, 2025 09:22
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 12, 2025
@webfiltered webfiltered enabled auto-merge (squash) February 12, 2025 09:22
@webfiltered webfiltered disabled auto-merge February 12, 2025 10:28
@webfiltered webfiltered marked this pull request as draft February 12, 2025 15:20
@robinjhuang
Copy link
Member

We would need to delete debug_windows since it's not being used now.

I think it's cleaner to have a "debug" action for each OS though. What if we do this? Move the integration_test_windows.yml steps into debug_windows.yml and remove integration_test_windows.yml?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants