Skip to content

test: avoid public hygiene false positive on client-id carrier - #979

Merged
christian-byrne merged 1 commit into
glary/run-share-client-idfrom
agent/op511-cli970-hygiene
Oct 7, 2026
Merged

christian-byrne merged 1 commit into
glary/run-share-client-idfrom
agent/op511-cli970-hygiene

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Fixes the only failing check on #970. The redaction test used SECRET-123, which the public-repo hygiene scanner correctly interpreted as an internal-ticket-shaped identifier. This keeps the secret-redaction assertion while using a non-ticket-shaped sentinel.

Validation:

  • pytest -q tests/comfy_cli/command/test_run_client_id.py::TestAnAlreadyTerminalFailureIsTrimmedToo (3 passed)
  • ruff check tests/comfy_cli/command/test_run_client_id.py
  • ruff format --check tests/comfy_cli/command/test_run_client_id.py
  • git diff --check

@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 329ca308-5986-49fb-965e-b81ed17cca5a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@christian-byrne
christian-byrne merged commit 0ce680e into glary/run-share-client-id Oct 7, 2026
6 checks passed
@christian-byrne
christian-byrne deleted the agent/op511-cli970-hygiene branch October 7, 2026 06:07
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant