Repository navigation
test: avoid public hygiene false positive on client-id carrier - #979
Merged
christian-byrne merged 1 commit intoOct 7, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the only failing check on #970. The redaction test used
SECRET-123, which the public-repo hygiene scanner correctly interpreted as an internal-ticket-shaped identifier. This keeps the secret-redaction assertion while using a non-ticket-shaped sentinel.Validation:
pytest -q tests/comfy_cli/command/test_run_client_id.py::TestAnAlreadyTerminalFailureIsTrimmedToo(3 passed)ruff check tests/comfy_cli/command/test_run_client_id.pyruff format --check tests/comfy_cli/command/test_run_client_id.pygit diff --check