fix: Conditionally hide bottom border in missing nodes modal on non-cloud environments #6779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
🎭 Playwright Test Results⏰ Completed at: 11/20/2025, 09:06:11 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/20/2025, 08:55:28 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.13 MB (baseline 3.13 MB) • 🔴 +25 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 945 kB (baseline 945 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 7.97 kB (baseline 7.97 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 306 kB (baseline 306 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 141 kB (baseline 141 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.87 MB (baseline 3.87 MB) • ⚪ 0 BBundles that do not match a named category
Status: 18 added / 18 removed |
christian-byrne
approved these changes
Nov 20, 2025
christian-byrne
added
needs-backport
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
…loud environments (#6779) ## Summary - Conditionally hide the bottom border of the missing nodes modal content when not running in cloud environment - The footer is not visible in non-cloud environments, so the bottom border was appearing disconnected ## Changes - Added conditional `border-b-1` class based on `isCloud` flag in `MissingNodesContent.vue` - Keeps top border visible in all environments - Bottom border only shows in cloud environment where footer is present ## Test plan - [ ] Open missing nodes dialog in cloud environment - bottom border should be visible - [ ] Open missing nodes dialog in non-cloud environment - bottom border should be hidden - [ ] Verify top border remains visible in both environments ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6779-fix-Conditionally-hide-bottom-border-in-missing-nodes-modal-on-non-cloud-environments-2b16d73d365081cea1c8c98b11878045) by [Unito](https://www.unito.io)
Member
|
@viva-jinyi Successfully backported to #6790 |
github-actions
bot
removed
the
needs-backport
christian-byrne
pushed a commit
that referenced
this pull request
Nov 21, 2025
… nodes modal on non-cloud environments (#6790) Backport of #6779 to `core/1.32` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6790-backport-core-1-32-fix-Conditionally-hide-bottom-border-in-missing-nodes-modal-on-non--2b16d73d36508172be63cc0e2ccb0554) by [Unito](https://www.unito.io) Co-authored-by: Jin Yi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
border-b-1class based onisCloudflag inMissingNodesContent.vueTest plan
┆Issue is synchronized with this Notion page by Unito