fix: node deletion handling in vue nodes when switching from litegrap… #5909
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 10/04/2025, 02:04:03 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 10/04/2025, 02:14:46 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
DrJKL
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix node deletion when switching from litegraph -> vue node mode.
Background:
There is a race condition where we have 2 watch() functions that are both tracking shouldRenderVueNodes.value:
Each watch() separately sets graph.onNodeRemoved to its own cleanup handler. But without flush: 'sync', the slot sync watch runs AFTER vue nodes and overwrites the callback. So when deletion happens, graph.onNodeRemoved points to the slot handler (or undefined) instead of the vue cleanup handler, and the vue node never gets removed from the DOM.
Review Focus
We are making use of the watch() option "fush: sync" in the link and slot watch() so maybe there is side effects from firing this when dependencies change synchronously.
Screenshots (if applicable)
vue-nodes-fix-delete-node.mp4
┆Issue is synchronized with this Notion page by Unito