Style: Make components themeable #5908
Open
+355
−221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 10/05/2025, 07:52:27 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 10/05/2025, 08:05:22 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
DrJKL
requested review from
viva-jinyi,
christian-byrne,
ltdrdata,
arjansingh,
jtydhr88,
Myestery,
pythongosssss and
webfiltered
as code owners
dosubot
bot
added
the
size:L
Myestery
previously approved these changes
Oct 4, 2025
src/services/colorPaletteService.ts
Outdated
| WIDGET_TEXT_COLOR: 'node-component-widget-input' | ||
| // /* TOGGLE | ||
| } as const satisfies Partial<Record<keyof Colors['litegraph_base'], string>> | ||
| /*/ |
There was a problem hiding this comment.
nit: we can take away this comment
There was a problem hiding this comment.
Yes, but it's useful to see which properties haven't yet had equivalent tokens defined.
christian-byrne
added
the
claude-review
DrJKL
added
the
New Browser Test Expectations
DrJKL
added
New Browser Test Expectations
arjansingh
previously approved these changes
Oct 5, 2025
|
|
||
| ## Icon Usage in Storybook | ||
|
|
||
| In this project, the `<i-lucide:... />` syntax from unplugin-icons is not supported in Storybook. |
There was a problem hiding this comment.
Claude and Codex thank you.
| ## Icon Usage in Storybook | ||
|
|
||
| In this project, the `<i-lucide:... />` syntax from unplugin-icons is not supported in Storybook. | ||
| In this project, the `<i class="icon-[lucide--folder]" />` syntax from unplugin-icons is not supported in Storybook. |
There was a problem hiding this comment.
non-blocker: This should go in the root CLAUDE.md as well. Will prevent many bad generations.
| root: { | ||
| class: | ||
| '!w-7 !h-7 !border-none !outline-none !p-2 !m-1.5 bg-gray-500 dark-theme:bg-neutral-700 text-white' | ||
| '!w-7 !h-7 !border-none !outline-none !p-2 !m-1.5 bg-dialog-surface text-white' |
There was a problem hiding this comment.
non-blocker: this is where we'd have to start removing !importants if we wanted to fix the dialogs.
DrJKL
added
New Browser Test Expectations
DrJKL
added
New Browser Test Expectations
dosubot
bot
added
size:S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace color/dark-color pairs in components with design tokens to allow for easy overriding.
Also standardizes the icon pattern to simplify the tailwind config.
Changes
Review Focus
Still have quite a few places from which to remove
dark-theme, but this at least gets the theming much closer.Need to decide if I want to keep going in here or cut this and do the rest in a subsequent PR.
Screenshots (if applicable)
┆Issue is synchronized with this Notion page by Unito