Skip to content

pass nodeId to widget component #5853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2025
Merged

pass nodeId to widget component #5853

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11fef8e
pass nodeData to widget component
jtydhr88 Sep 30, 2025
286b738
pass nodeId to widget component
jtydhr88 Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/renderer/extensions/vueNodes/components/NodeWidgets.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
:widget="widget.simplified"
:model-value="widget.value"
:readonly="readonly"
:node-id="nodeData?.id != null ? String(nodeData.id) : ''"
Copy link
Contributor

@webfiltered webfiltered Oct 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pattern is everywhere and doesn't make sense - nodeId is defined as optional (string | undefined), yet we're forcing it to empty string for some reason? Is that actually valid?

Copy link
Collaborator Author

@jtydhr88 jtydhr88 Oct 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I just copy this line from above code in the same file, and follow the same pattern what I see...

Copy link
Contributor

@DrJKL DrJKL Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @webfiltered that we should remove the check and conversion later.

class="flex-1"
@update:model-value="widget.updateHandler"
/>
Expand Down