Skip to content

fix: prevent splitter overlay from loading in focus mode #5670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: prevent splitter overlay from loading in focus mode #5670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa24595
fix: prevent splitter overlay from loading in focus mode
Myestery Sep 19, 2025
e55b28d
fix: ensure GraphCanvasMenu and MiniMap are displayed correctly based…
Myestery Sep 19, 2025
25a70e2
Merge branch 'main' into 5658-bug-focus-mode
Myestery Sep 19, 2025
2faf35d
Update test expectations [skip ci]
invalid-email-address Sep 22, 2025
e77af0a
Merge branch 'main' into 5658-bug-focus-mode
Myestery Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...olorPalette.spec.ts-snapshots/custom-color-palette-light-red-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...c.ts-snapshots/custom-color-palette-obsidian-dark-all-colors-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...Palette.spec.ts-snapshots/custom-color-palette-obsidian-dark-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...s/tests/colorPalette.spec.ts-snapshots/default-color-palette-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...s/tests/colorPalette.spec.ts-snapshots/node-lightened-colors-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ts/colorPalette.spec.ts-snapshots/node-opacity-0-2-arc-theme-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...olorPalette.spec.ts-snapshots/node-opacity-0-3-color-changed-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...olorPalette.spec.ts-snapshots/node-opacity-0-3-color-removed-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ..._tests/tests/colorPalette.spec.ts-snapshots/node-opacity-0-5-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...er_tests/tests/colorPalette.spec.ts-snapshots/node-opacity-1-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified browser_tests/tests/copyPaste.spec.ts-snapshots/copied-node-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ests/tests/copyPaste.spec.ts-snapshots/copied-node-with-link-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ..._tests/tests/copyPaste.spec.ts-snapshots/copied-widget-value-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ests/tests/copyPaste.spec.ts-snapshots/drag-copy-copied-node-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified browser_tests/tests/copyPaste.spec.ts-snapshots/no-node-copied-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ....ts-snapshots/paste-in-text-area-with-node-previously-copied-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified browser_tests/tests/domWidget.spec.ts-snapshots/focus-mode-on-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...execution.spec.ts-snapshots/execution-error-unconnected-slot-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...s/graphCanvasMenu.spec.ts-snapshots/canvas-with-hidden-links-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../graphCanvasMenu.spec.ts-snapshots/canvas-with-visible-links-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ts/tests/interaction.spec.ts-snapshots/adjusted-widget-value-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...action.spec.ts-snapshots/batch-disconnect-links-disconnected-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...r_tests/tests/interaction.spec.ts-snapshots/batch-move-links-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...s/tests/interaction.spec.ts-snapshots/batch-move-links-moved-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified browser_tests/tests/interaction.spec.ts-snapshots/default-chromium-2x-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified browser_tests/tests/interaction.spec.ts-snapshots/default-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/interaction.spec.ts-snapshots/deleted-all-chromium-linux.png
View file
Open in desktop
Binary file modified ..._tests/tests/interaction.spec.ts-snapshots/disconnected-edge-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/interaction.spec.ts-snapshots/dragged-node1-chromium-linux.png
View file
Open in desktop
Binary file modified ...ser_tests/tests/interaction.spec.ts-snapshots/dragging-link1-chromium-linux.png
View file
Open in desktop
Binary file modified ...ser_tests/tests/interaction.spec.ts-snapshots/dragging-link2-chromium-linux.png
View file
Open in desktop
Binary file modified ...ts/tests/interaction.spec.ts-snapshots/group-fit-to-contents-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/tests/interaction.spec.ts-snapshots/group-selected-nodes-chromium-linux.png
View file
Open in desktop
Binary file modified ...tests/tests/interaction.spec.ts-snapshots/group-title-edited-chromium-linux.png
View file
Open in desktop
Binary file modified ...ts/tests/interaction.spec.ts-snapshots/legacy-alt-shift-drag-chromium-linux.png
View file
Open in desktop
Binary file modified ...tests/interaction.spec.ts-snapshots/legacy-click-node-select-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/tests/interaction.spec.ts-snapshots/legacy-left-drag-pan-chromium-linux.png
View file
Open in desktop
Binary file modified ...s/tests/interaction.spec.ts-snapshots/legacy-middle-drag-pan-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/tests/interaction.spec.ts-snapshots/legacy-wheel-zoom-in-chromium-linux.png
View file
Open in desktop
Binary file modified ...ts/tests/interaction.spec.ts-snapshots/legacy-wheel-zoom-out-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/interaction.spec.ts-snapshots/moved-link-chromium-linux.png
View file
Open in desktop
Binary file modified ..._tests/tests/interaction.spec.ts-snapshots/node-title-edited-chromium-linux.png
View file
Open in desktop
Binary file modified ...ser_tests/tests/interaction.spec.ts-snapshots/nodes-bypassed-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/interaction.spec.ts-snapshots/nodes-pinned-chromium-linux.png
View file
Open in desktop
Binary file modified ...r_tests/tests/interaction.spec.ts-snapshots/nodes-unbypassed-chromium-linux.png
View file
Open in desktop
Binary file modified ...ser_tests/tests/interaction.spec.ts-snapshots/nodes-unpinned-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/tests/interaction.spec.ts-snapshots/panned-back-from-far-chromium-linux.png
View file
Open in desktop
Binary file modified ...tests/tests/interaction.spec.ts-snapshots/panned-back-to-one-chromium-linux.png
View file
Open in desktop
Binary file modified ...tests/tests/interaction.spec.ts-snapshots/panned-back-to-two-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/interaction.spec.ts-snapshots/panned-chromium-linux.png
View file
Open in desktop
Binary file modified ...er_tests/tests/interaction.spec.ts-snapshots/panned-far-away-chromium-linux.png
View file
Open in desktop
Binary file modified ...er_tests/tests/interaction.spec.ts-snapshots/panned-step-one-chromium-linux.png
View file
Open in desktop
Binary file modified ...er_tests/tests/interaction.spec.ts-snapshots/panned-step-two-chromium-linux.png
View file
Open in desktop
Binary file modified ..._tests/tests/interaction.spec.ts-snapshots/panned-touch-mobile-chrome-linux.png
View file
Open in desktop
Binary file modified ...sts/interaction.spec.ts-snapshots/panning-when-dragging-link-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/interaction.spec.ts-snapshots/pinned-all-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/tests/interaction.spec.ts-snapshots/prompt-dialog-closed-chromium-linux.png
View file
Open in desktop
Binary file modified ...ests/interaction.spec.ts-snapshots/prompt-dialog-closed-text-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/tests/interaction.spec.ts-snapshots/prompt-dialog-opened-chromium-linux.png
View file
Open in desktop
Binary file modified ...ests/interaction.spec.ts-snapshots/prompt-dialog-opened-text-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/interaction.spec.ts-snapshots/selected-all-chromium-linux.png
View file
Open in desktop
Binary file modified ..._tests/tests/interaction.spec.ts-snapshots/selected-node1-chromium-2x-linux.png
View file
Open in desktop
Binary file modified ...ser_tests/tests/interaction.spec.ts-snapshots/selected-node1-chromium-linux.png
View file
Open in desktop
Binary file modified ..._tests/tests/interaction.spec.ts-snapshots/selected-node2-chromium-2x-linux.png
View file
Open in desktop
Binary file modified ...ser_tests/tests/interaction.spec.ts-snapshots/selected-node2-chromium-linux.png
View file
Open in desktop
Binary file modified ...er_tests/tests/interaction.spec.ts-snapshots/single-ksampler-chromium-linux.png
View file
Open in desktop
Binary file modified ...ests/tests/interaction.spec.ts-snapshots/single-ksampler-fit-chromium-linux.png
View file
Open in desktop
Binary file modified ...tests/interaction.spec.ts-snapshots/single-ksampler-modified-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/interaction.spec.ts-snapshots/snap-to-slot-chromium-linux.png
View file
Open in desktop
Binary file modified ...ests/tests/interaction.spec.ts-snapshots/snap-to-slot-linked-chromium-linux.png
View file
Open in desktop
Binary file modified ...ests/tests/interaction.spec.ts-snapshots/snapped-highlighted-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/interaction.spec.ts-snapshots/standard-click-node-select-chromium-linux.png
View file
Open in desktop
Binary file modified ...ts/interaction.spec.ts-snapshots/standard-ctrl-wheel-zoom-in-chromium-linux.png
View file
Open in desktop
Binary file modified ...s/interaction.spec.ts-snapshots/standard-ctrl-wheel-zoom-out-chromium-linux.png
View file
Open in desktop
Binary file modified ...ests/interaction.spec.ts-snapshots/standard-left-drag-select-chromium-linux.png
View file
Open in desktop
Binary file modified ...tests/interaction.spec.ts-snapshots/standard-middle-drag-pan-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/interaction.spec.ts-snapshots/string-input-chromium-linux.png
View file
Open in desktop
Binary file modified ...ser_tests/tests/interaction.spec.ts-snapshots/string-node-id-chromium-linux.png
View file
Open in desktop
Binary file modified .../interaction.spec.ts-snapshots/text-encode-toggled-back-open-chromium-linux.png
View file
Open in desktop
Binary file modified .../tests/interaction.spec.ts-snapshots/text-encode-toggled-off-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/interaction.spec.ts-snapshots/unpinned-all-chromium-linux.png
View file
Open in desktop
Binary file modified ...ser_tests/tests/interaction.spec.ts-snapshots/zoomed-back-in-chromium-linux.png
View file
Open in desktop
Binary file modified ...ests/interaction.spec.ts-snapshots/zoomed-default-ctrl-shift-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/interaction.spec.ts-snapshots/zoomed-in-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/tests/interaction.spec.ts-snapshots/zoomed-in-ctrl-shift-chromium-linux.png
View file
Open in desktop
Binary file modified ...ests/interaction.spec.ts-snapshots/zoomed-in-high-zoom-speed-chromium-linux.png
View file
Open in desktop
Binary file modified ...tests/interaction.spec.ts-snapshots/zoomed-in-low-zoom-speed-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/interaction.spec.ts-snapshots/zoomed-out-chromium-linux.png
View file
Open in desktop
Binary file modified ...ts/tests/interaction.spec.ts-snapshots/zoomed-out-ctrl-shift-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/interaction.spec.ts-snapshots/zoomed-out-high-zoom-speed-chromium-linux.png
View file
Open in desktop
Binary file modified ...ests/interaction.spec.ts-snapshots/zoomed-out-low-zoom-speed-chromium-linux.png
View file
Open in desktop
Binary file modified ...ests/tests/interaction.spec.ts-snapshots/zoomed-very-far-out-chromium-linux.png
View file
Open in desktop
Binary file modified ...ec.ts-snapshots/dropped-workflow-url-hidream-dev-example-png-chromium-linux.png
View file
Open in desktop
Binary file modified ...s/loadWorkflowInMedia.spec.ts-snapshots/edited-workflow-webp-chromium-linux.png
View file
Open in desktop
Binary file modified ...ts/loadWorkflowInMedia.spec.ts-snapshots/large-workflow-webp-chromium-linux.png
View file
Open in desktop
Binary file modified ...tests/loadWorkflowInMedia.spec.ts-snapshots/no-workflow-webp-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-m4v-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-mov-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-mp4-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-svg-chromium-linux.png
View file
Open in desktop
Binary file modified ...ts/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-webm-chromium-linux.png
View file
Open in desktop
Binary file modified ...ts/tests/loadWorkflowInMedia.spec.ts-snapshots/workflow-webp-chromium-linux.png
View file
Open in desktop
Binary file modified ...s/lodThreshold.spec.ts-snapshots/lod-comparison-high-quality-chromium-linux.png
View file
Open in desktop
Binary file modified ...ts/lodThreshold.spec.ts-snapshots/lod-comparison-low-quality-chromium-linux.png
View file
Open in desktop
Binary file modified ...s/tests/nodeBadge.spec.ts-snapshots/node-badge-Hide-built-in-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-None-chromium-linux.png
View file
Open in desktop
Binary file modified ..._tests/tests/nodeBadge.spec.ts-snapshots/node-badge-Show-all-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/nodeBadge.spec.ts-snapshots/node-badge-left-chromium-linux.png
View file
Open in desktop
Binary file modified ...s/nodeBadge.spec.ts-snapshots/node-badge-light-color-palette-chromium-linux.png
View file
Open in desktop
Binary file modified ..._tests/tests/nodeBadge.spec.ts-snapshots/node-badge-multiple-chromium-linux.png
View file
Open in desktop
Binary file modified ...nodeBadge.spec.ts-snapshots/node-badge-unknown-color-palette-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/nodeDisplay.spec.ts-snapshots/default-input-chromium-linux.png
View file
Open in desktop
Binary file modified .../tests/nodeDisplay.spec.ts-snapshots/dynamically-added-input-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/nodeDisplay.spec.ts-snapshots/force-input-chromium-linux.png
View file
Open in desktop
Binary file modified ...nodeDisplay.spec.ts-snapshots/missing-nodes-converted-widget-chromium-linux.png
View file
Open in desktop
Binary file modified ...ser_tests/tests/nodeDisplay.spec.ts-snapshots/optional-input-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/nodeDisplay.spec.ts-snapshots/simple-slider-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/nodeSearchBox.spec.ts-snapshots/added-node-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/nodeSearchBox.spec.ts-snapshots/added-node-no-connection-chromium-linux.png
View file
Open in desktop
Binary file modified ...tests/nodeSearchBox.spec.ts-snapshots/auto-linked-node-batch-chromium-linux.png
View file
Open in desktop
Binary file modified ...tests/tests/nodeSearchBox.spec.ts-snapshots/auto-linked-node-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/nodeSearchBox.spec.ts-snapshots/link-context-menu-search-chromium-linux.png
View file
Open in desktop
Binary file modified ...ts/nodeSearchBox.spec.ts-snapshots/link-release-context-menu-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/noteNode.spec.ts-snapshots/note-nodes-chromium-linux.png
View file
Open in desktop
Binary file modified ...r_tests/tests/primitiveNode.spec.ts-snapshots/primitive-node-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/primitiveNode.spec.ts-snapshots/primitive-node-connected-chromium-linux.png
View file
Open in desktop
Binary file modified ...veNode.spec.ts-snapshots/primitive-node-connected-dom-widget-chromium-linux.png
View file
Open in desktop
Binary file modified ...s/primitiveNode.spec.ts-snapshots/static-primitive-connected-chromium-linux.png
View file
Open in desktop
Binary file modified .../rerouteNode.spec.ts-snapshots/native-reroute-alt-click-chromium-0-5x-linux.png
View file
Open in desktop
Binary file modified ...ts/rerouteNode.spec.ts-snapshots/native-reroute-alt-click-chromium-2x-linux.png
View file
Open in desktop
Binary file modified ...tests/rerouteNode.spec.ts-snapshots/native-reroute-alt-click-chromium-linux.png
View file
Open in desktop
Binary file modified ...ser_tests/tests/rerouteNode.spec.ts-snapshots/native-reroute-chromium-linux.png
View file
Open in desktop
Binary file modified ...ts/rerouteNode.spec.ts-snapshots/native-reroute-context-menu-chromium-linux.png
View file
Open in desktop
Binary file modified ...s-snapshots/native-reroute-delete-from-midpoint-context-menu-chromium-linux.png
View file
Open in desktop
Binary file modified ...r_tests/tests/rerouteNode.spec.ts-snapshots/reroute-inserted-chromium-linux.png
View file
Open in desktop
Binary file modified ...tests/rightClickMenu.spec.ts-snapshots/add-group-group-added-chromium-linux.png
View file
Open in desktop
Binary file modified ...s/tests/rightClickMenu.spec.ts-snapshots/add-node-node-added-chromium-linux.png
View file
Open in desktop
Binary file modified ...ser_tests/tests/rightClickMenu.spec.ts-snapshots/node-pinned-chromium-linux.png
View file
Open in desktop
Binary file modified ...ests/tests/rightClickMenu.spec.ts-snapshots/right-click-menu-chromium-linux.png
View file
Open in desktop
Binary file modified ...s/rightClickMenu.spec.ts-snapshots/right-click-node-bypassed-chromium-linux.png
View file
Open in desktop
Binary file modified ...ests/tests/rightClickMenu.spec.ts-snapshots/right-click-node-chromium-linux.png
View file
Open in desktop
Binary file modified ...ClickMenu.spec.ts-snapshots/right-click-node-collapsed-badge-chromium-linux.png
View file
Open in desktop
Binary file modified .../rightClickMenu.spec.ts-snapshots/right-click-node-collapsed-chromium-linux.png
View file
Open in desktop
Binary file modified ...rightClickMenu.spec.ts-snapshots/right-click-node-group-node-chromium-linux.png
View file
Open in desktop
Binary file modified ...lickMenu.spec.ts-snapshots/right-click-node-properties-panel-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/rightClickMenu.spec.ts-snapshots/right-click-pinned-node-chromium-linux.png
View file
Open in desktop
Binary file modified ...s/rightClickMenu.spec.ts-snapshots/right-click-unpinned-node-chromium-linux.png
View file
Open in desktop
Binary file modified ...tClickMenu.spec.ts-snapshots/right-click-unpinned-node-moved-chromium-linux.png
View file
Open in desktop
Binary file modified ...ests/tests/rightClickMenu.spec.ts-snapshots/selected-2-nodes-chromium-linux.png
View file
Open in desktop
Binary file modified ...tests/rightClickMenu.spec.ts-snapshots/selected-nodes-pinned-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/rightClickMenu.spec.ts-snapshots/selected-nodes-unpinned-chromium-linux.png
View file
Open in desktop
Binary file modified ...ox.spec.ts-snapshots/selection-toolbox-multiple-nodes-border-chromium-linux.png
View file
Open in desktop
Binary file modified ...ec.ts-snapshots/selection-toolbox-multiple-selections-border-chromium-linux.png
View file
Open in desktop
Binary file modified ...ox.spec.ts-snapshots/selection-toolbox-single-node-no-border-chromium-linux.png
View file
Open in desktop
Binary file modified ...ec.ts-snapshots/selection-toolbox-single-selection-no-border-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/widget.spec.ts-snapshots/boolean-widget-chromium-linux.png
View file
Open in desktop
Binary file modified ..._tests/tests/widget.spec.ts-snapshots/boolean-widget-toggled-chromium-linux.png
View file
Open in desktop
Binary file modified ...sts/widget.spec.ts-snapshots/empty-latent-resized-80-percent-chromium-linux.png
View file
Open in desktop
Binary file modified ...idget.spec.ts-snapshots/image-preview-changed-by-combo-value-chromium-linux.png
View file
Open in desktop
Binary file modified ...ests/widget.spec.ts-snapshots/image-preview-drag-and-dropped-chromium-linux.png
View file
Open in desktop
Binary file modified ...ts/tests/widget.spec.ts-snapshots/ksampler-resized-min-width-chromium-linux.png
View file
Open in desktop
Binary file modified ...r_tests/tests/widget.spec.ts-snapshots/ksampler-widget-added-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/widget.spec.ts-snapshots/load-audio-widget-chromium-linux.png
View file
Open in desktop
Binary file modified ...s/widget.spec.ts-snapshots/load-checkpoint-resized-min-width-chromium-linux.png
View file
Open in desktop
Binary file modified browser_tests/tests/widget.spec.ts-snapshots/load-image-widget-chromium-linux.png
View file
Open in desktop
Binary file modified ...ser_tests/tests/widget.spec.ts-snapshots/resized-to-original-chromium-linux.png
View file
Open in desktop
Binary file modified ...ser_tests/tests/widget.spec.ts-snapshots/seed-widget-dragged-chromium-linux.png
View file
Open in desktop
Binary file modified ...r_tests/tests/widget.spec.ts-snapshots/slider-widget-dragged-chromium-linux.png
View file
Open in desktop
14 changes: 5 additions & 9 deletions src/components/graph/GraphCanvas.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
<!-- Load splitter overlay only after comfyApp is ready. -->
<!-- If load immediately, the top-level splitter stateKey won't be correctly
synced with the stateStorage (localStorage). -->
<LiteGraphCanvasSplitterOverlay v-if="comfyAppReady && betaMenuEnabled">
<LiteGraphCanvasSplitterOverlay
v-if="comfyAppReady && betaMenuEnabled && !workspaceStore.focusMode"
>
<template v-if="!workspaceStore.focusMode" #side-bar-panel>
<SideToolbar />
</template>
Expand All @@ -15,22 +17,16 @@
v-if="workflowTabsPosition === 'Topbar (2nd-row)'"
/>
</div>
<GraphCanvasMenu v-if="canvasMenuEnabled" class="pointer-events-auto" />

<MiniMap
v-if="comfyAppReady && minimapEnabled"
class="pointer-events-auto"
/>
</template>
</LiteGraphCanvasSplitterOverlay>
<GraphCanvasMenu v-if="!betaMenuEnabled && canvasMenuEnabled" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we accidentally dropped the !betaMenuEnabled check here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I dropped it because we had 2 Graphcanvas components and thebetaMenuEnabled check was logically irrelevant

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 GraphCanvasMenu components? Apologies for not understanding

<GraphCanvasMenu v-if="canvasMenuEnabled" class="pointer-events-auto" />
<MiniMap v-if="comfyAppReady && minimapEnabled" class="pointer-events-auto" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to above, the MiniMap was previously inside of a parent that only rendered when !betaMenuEnabled, so now we may need to move that condition directly into the v-if here.

<canvas
id="graph-canvas"
ref="canvasRef"
tabindex="1"
class="align-top w-full h-full touch-none"
/>

<!-- TransformPane for Vue node rendering -->
<TransformPane
v-if="shouldRenderVueNodes && comfyApp.canvas && comfyAppReady"
Expand Down
Loading