fix: about panel error when device not supplied in system_stats response
#5666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or on undefined device Tests reproduce the exact error: "TypeError: Cannot read properties of undefined (reading 'name')" occurring in DeviceInfo component when props.device is undefined. Root cause scenarios tested: - DeviceInfo component receives undefined device prop - SystemStatsPanel passes undefined device when devices array is empty - API response malformation leading to missing device data - Edge cases with corrupted or missing SystemStats data Sentry URL: https://comfy-org.sentry.io/issues/6804418395/?project=4509681221369857 Tests currently fail as expected, proving the bug exists. Next: implement defensive programming to handle undefined device props.
…ndefined device Fixes TypeError: Cannot read properties of undefined (reading 'name') occurring in DeviceInfo component when device prop is undefined. Changes: - DeviceInfo: Add null checks and graceful error handling for undefined device prop - DeviceInfo: Enhanced formatValue to return 'N/A' for null/undefined values - SystemStatsPanel: Add guard clauses for empty devices array - SystemStatsPanel: Display helpful message when no devices available - Added monitoring to log when devices array is missing for debugging - Added i18n keys for error messages Root cause: Component attempted to access properties on undefined device object when SystemStats API returned empty devices array or malformed data. Solution: Defensive programming with null checks and user-friendly error messages. Tests updated to verify graceful handling instead of throwing errors. Sentry URL: https://comfy-org.sentry.io/issues/6804418395/?project=4509681221369857
christian-byrne
requested review from
Yorha4D,
KarryCharon,
shinshin86 and
a team
as code owners
dosubot
bot
added
the
size:L
🎭 Playwright Test Results⏰ Completed at: 09/19/2025, 08:58:42 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
christian-byrne
changed the title
system_stats response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed CLOUD-FRONTEND-STAGING-13 where DeviceInfo component throws TypeError when accessing undefined device properties.
Root Cause:
SystemStats API returning empty
devicesarray causedprops.stats.devices[0]to be undefined, leading to property access errors in Vue template rendering.Changes
Review Focus
Component prop validation and error boundary patterns for handling malformed API responses. The watchEffect debugging hook logs missing devices scenarios without impacting production performance.
┆Issue is synchronized with this Notion page by Unito