Skip to content

Update locales for node definitions #4019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 1, 2025

Conversation

comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented May 30, 2025

Automated PR to update locales for node definitions

This PR was created automatically by the frontend update workflow.

┆Issue is synchronized with this Notion page by Unito

@comfy-pr-bot comfy-pr-bot added the dependencies Pull requests that update a dependency file label May 30, 2025
@christian-byrne
Copy link
Contributor

christian-byrne commented May 30, 2025

Todo before merging:

@christian-byrne christian-byrne force-pushed the update-locales-node-defs-manual-15336380621 branch from 03d64bd to 212a73e Compare June 1, 2025 11:55
@christian-byrne
Copy link
Contributor

Single test failure from LoadAudio display name updating in core:

Selection_1460

Updating test expectations.

@christian-byrne christian-byrne added the New Browser Test Expectations New browser test screenshot should be set by github action label Jun 1, 2025
christian-byrne and others added 4 commits June 1, 2025 06:08
Converts malformed outputs arrays back to correct object structure:
- Arrays with null values: [null, null, {name: 'foo'}]
- Back to objects: {'0': {name: 'foo'}}

Applied fix-translated-outputs.cjs script to repair translation service errors.
@christian-byrne christian-byrne force-pushed the update-locales-node-defs-manual-15336380621 branch from b6e2d03 to 69b0c06 Compare June 1, 2025 13:08
@christian-byrne christian-byrne merged commit ac01bff into main Jun 1, 2025
2 checks passed
@christian-byrne christian-byrne deleted the update-locales-node-defs-manual-15336380621 branch June 1, 2025 13:46
webfiltered added a commit that referenced this pull request Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file New Browser Test Expectations New browser test screenshot should be set by github action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants