Skip to content

fix: accept py3-none torchvision/torchaudio nightly wheels in refresh - #25

Merged
benceruleanlu merged 1 commit into
mainfrom
fix/nightly-py3-none-wheels
Oct 24, 2026
Merged

benceruleanlu merged 1 commit into
mainfrom
fix/nightly-py3-none-wheels

Conversation

@benceruleanlu

Copy link
Copy Markdown
Member

Since 2026-10-08, PyTorch publishes nightly torchvision and torchaudio as py3-none-<platform> wheels instead of one cpXY-cpXY wheel per Python version (on cu132 and cu130). abi_for_wheel dropped them, so the newest date with all three packages recognised stayed at 2026-10-07 and Refresh Nightly Torch Stacks has failed daily with cu132: no coherent torch/torchvision/torchaudio triple within 7 days.

py3-none wheels now parse to an any ABI that fits every Python version, so pythonAbis comes from the packages that still publish per-version wheels (torch). A date where every package is any yields no ABI and is skipped.

Tests: py3-none parsing, torch + py3-none companions resolving, all-any rejected. They fail on main and pass here. A local run against the live index resolves to 2026-10-23; the manifest rewrite itself is left to the scheduled workflow.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: db181ce7-4427-43d9-8eec-a094c8be472c
📥 Commits

Reviewing files that changed from the base of the PR and between 8ffa110 and 258f5d0.

📒 Files selected for processing: 2
  • scripts/refresh_nightly_stacks.py
  • scripts/test_torch_index_scripts.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The script now accepts py3-none wheels as universal ABI entries and uses concrete ABI sets to resolve package tags. Tests cover platform filtering, universal companion wheels, and the case where no concrete ABI is available.

Changes: Universal Wheel ABI Resolution

Layer / File(s) Summary
Wheel ABI representation and parsing
scripts/refresh_nightly_stacks.py, scripts/test_torch_index_scripts.py
abi_for_wheel maps py3-none wheels to ANY_ABI. Parser tests cover Windows and x86_64 Linux wheels and exclude aarch64 Linux wheels.
Shared ABI resolution
scripts/refresh_nightly_stacks.py, scripts/test_torch_index_scripts.py
resolve_tag uses shared_abis to find concrete ABIs. Tests cover universal companion wheels resolving with Torch’s concrete ABIs and the all-universal case returning no entry and an error.

Suggested reviewers: kosinkadink

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to 258f5

The change appears ready to merge after normal checks; no actionable compatibility issue was identified.

Pre-merge checks: Passed 2
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@benceruleanlu
benceruleanlu merged commit fe00ec4 into main Oct 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant