Skip to content

Conversation

@ViralReaction
Copy link
Contributor

@ViralReaction ViralReaction commented Jan 1, 2026

Changes

Describe adjustments to existing features made in this merge, e.g.

  • Fixes edge case of not having armor pen values by adding check for damage def default armor pen prior to default fallback of 50. No longer have the below messages for projectiles that come from apparel.
image

Reasoning

Why did you choose to implement things this way, e.g.

  • Fixes error that could have better armor pen

Alternatives

Describe alternative implementations you have considered, e.g.

  • Annoying message popup
  • Slower but more versatile mod extension check on dinfo.Weapon but doesn't fix issues if null.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@ViralReaction ViralReaction requested review from a team as code owners January 1, 2026 20:13
@github-actions
Copy link

github-actions bot commented Jan 1, 2026

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20644877067.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jan 1, 2026
@N7Huntsman N7Huntsman merged commit aa3a544 into Development Jan 8, 2026
3 checks passed
@N7Huntsman N7Huntsman deleted the Fix-No-Pen-Info-Message branch January 8, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Download in Comments This PR has a zipfile download available.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants