Fix suppression decay after hunkering #4385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems theoretically possible for a hunkered pawn's suppression amount to decay below zero before the minimum hunkering period added in #4222 elapses. This would then cause the pawn's suppressed state to never be cleared. Fix the condition so this doesn't occur.
mszabo-wikia
force-pushed
the
suppression-decay-fix
branch
from
344b9aa to
162c104
Compare
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20411857096.zip |
github-actions
bot
added
the
Download in Comments
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20411879726.zip |
N7Huntsman
approved these changes
Dec 22, 2025
ViralReaction
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It seems theoretically possible for a hunkered pawn's suppression amount to decay below zero before the minimum hunkering period added in #4222 elapses. This would then cause the pawn's suppressed state to never be cleared. Fix the condition so this doesn't occur.
Testing
Check tests you have performed: