Skip to content

Conversation

@Keshash
Copy link
Contributor

@Keshash Keshash commented Aug 28, 2025

Additions

Describe new functionality added by your code, e.g.

  • Adds a new field for airburst projectiles: airburstDistanceOffset, which allows saying "explode 10 tiles before reaching the target" in xml.

Reasoning

Why did you choose to implement things this way, e.g.

  • Improves angled aerial explosions

Alternatives

Describe alternative implementations you have considered, e.g.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-17296282476.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Aug 28, 2025
@Keshash Keshash marked this pull request as ready for review October 7, 2025 14:11
@Keshash Keshash requested review from a team as code owners October 7, 2025 14:11
@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20480860989.zip

N7Huntsman
N7Huntsman previously approved these changes Dec 24, 2025
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my testing. Included adjustments to the frag angle to take advantage of the change. We'll likely also discuss increasing airburst frag count in the near future, but that's beyond the scope of this PR.

@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20493464082.zip

N7Huntsman
N7Huntsman previously approved these changes Dec 24, 2025
@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20493603817.zip

Safairette
Safairette previously approved these changes Dec 24, 2025
Copy link
Contributor

@Safairette Safairette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works. Though as noted, needs numbers tweaks to frag count to properly saturate the affected angle.

@N7Huntsman N7Huntsman dismissed stale reviews from Safairette and themself via 33916ed December 25, 2025 05:22
@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20499595502.zip

@N7Huntsman N7Huntsman merged commit 5bf6e8c into Development Dec 25, 2025
3 checks passed
@N7Huntsman N7Huntsman deleted the airburstDistanceOffset branch December 25, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Download in Comments This PR has a zipfile download available.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants