-
Notifications
You must be signed in to change notification settings - Fork 321
Add airburst distance offset #4199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-17296282476.zip |
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20480860989.zip |
N7Huntsman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works in my testing. Included adjustments to the frag angle to take advantage of the change. We'll likely also discuss increasing airburst frag count in the near future, but that's beyond the scope of this PR.
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20493464082.zip |
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20493603817.zip |
Safairette
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works. Though as noted, needs numbers tweaks to frag count to properly saturate the affected angle.
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-20499595502.zip |
Additions
Describe new functionality added by your code, e.g.
airburstDistanceOffset, which allows saying "explode 10 tiles before reaching the target" in xml.Reasoning
Why did you choose to implement things this way, e.g.
Alternatives
Describe alternative implementations you have considered, e.g.
Testing
Check tests you have performed: