Skip to content

fix: align provider icon within omniauth login button (#2795)#2999

Draft
alizaib1217 wants to merge 1 commit intomainfrom
fix/login-icon-alignment
Draft

fix: align provider icon within omniauth login button (#2795)#2999
alizaib1217 wants to merge 1 commit intomainfrom
fix/login-icon-alignment

Conversation

@alizaib1217
Copy link
Contributor

@alizaib1217 alizaib1217 commented Mar 6, 2026

  • rather 1-story 1-commit than sub-atomic commits

  • commit title is meaningful => git history search

  • commit description is helpful => helps the reviewer to understand the changes

  • code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured

  • added code is linted

  • tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited

  • in case the changes are visible to the end-user,  video or screenshots should be added to the PR => helps with user testing

  • testing coverage improvement is improved.

  • CHANGELOG :  add a bullet point on top (optional: reference to github issue/PR )

  • parallele PR for documentation  on docusaurus  if the feature/fix is tagged for a release

@alizaib1217 alizaib1217 requested a review from phuang26 March 6, 2026 10:14
@alizaib1217 alizaib1217 self-assigned this Mar 6, 2026
@alizaib1217 alizaib1217 linked an issue Mar 6, 2026 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

LCOV of commit 1083009 during CI - Ruby Lint, RSpec, and code coverage #1030

Summary coverage rate:
  lines......: 66.9% (18259 of 27303 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misaligned icon for "Login with OpenID Connect" button

1 participant