fix: element tab layout changes not applied on closing settings panel#2977
Open
alizaib1217 wants to merge 1 commit intomainfrom
Open
fix: element tab layout changes not applied on closing settings panel#2977alizaib1217 wants to merge 1 commit intomainfrom
alizaib1217 wants to merge 1 commit intomainfrom
Conversation
fix: force inventory tab visible when sample has inventory data
alizaib1217
force-pushed
the
fix/element-tab-layout-changes-not-applied
branch
from
4caab6f to
c4a3ff9
Compare
PiTrem
added a commit
that referenced
this pull request
Mar 2, 2026
PiTrem
added a commit
that referenced
this pull request
Mar 3, 2026
PiTrem
added a commit
that referenced
this pull request
Mar 3, 2026
PiTrem
added a commit
that referenced
this pull request
Mar 3, 2026
PiTrem
added a commit
that referenced
this pull request
Mar 3, 2026
PiTrem
added a commit
that referenced
this pull request
Mar 4, 2026
PiTrem
added a commit
that referenced
this pull request
Mar 4, 2026
PiTrem
added a commit
that referenced
this pull request
Mar 4, 2026
PiTrem
added a commit
that referenced
this pull request
Mar 5, 2026
PiTrem
added a commit
that referenced
this pull request
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug where changing tab visibility in the element settings panel had no effect when closing the panel
Inventory tab is now forced visible when a sample has inventory data, independently of collection layout settings
Fixes ComPlat/chemotion#479
rather 1-story 1-commit than sub-atomic commits
commit title is meaningful => git history search
commit description is helpful => helps the reviewer to understand the changes
code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured
added code is linted
tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited
in case the changes are visible to the end-user, video or screenshots should be added to the PR => helps with user testing
testing coverage improvement is improved.
CHANGELOG : add a bullet point on top (optional: reference to github issue/PR )
parallele PR for documentation on docusaurus if the feature/fix is tagged for a release