Conversation
- Add an interactive info popover next to the Inventory label field explaining where to create/assign inventory labels and the link to documentation of the feature. - Replace transient tooltip with a popover so the documentation link is clickable. - Improve user-facing error messages when no inventory label is found; point users to Account & Profile → Sample Inventory Label.
Closed
Contributor
Author
|
There was a problem hiding this comment.
Pull request overview
This pull request enhances user guidance for the inventory label feature by replacing a tooltip with an interactive Bootstrap Popover and improving error messaging. The changes provide clearer instructions on where to configure inventory labels and include a direct link to the documentation.
Changes:
- Added an info popover with detailed guidance next to the Inventory label field
- Improved error messages to provide specific navigation instructions to Account & Profile → Sample Inventory Label
- Refactored the inventory label section to accommodate the new info button alongside the label
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/javascript/src/apps/mydb/elements/details/samples/propertiesTab/SampleForm.js
Show resolved
Hide resolved
app/javascript/src/apps/mydb/elements/details/samples/propertiesTab/SampleForm.js
Outdated
Show resolved
Hide resolved
app/javascript/src/apps/mydb/elements/details/samples/propertiesTab/SampleForm.js
Outdated
Show resolved
Hide resolved
app/javascript/src/apps/mydb/elements/details/samples/propertiesTab/SampleForm.js
Show resolved
Hide resolved
TasnimMehzabin
approved these changes
Feb 26, 2026
adambasha0
force-pushed
the
add-info-button-for-inventory-label-field-in-sample-properties-tab
branch
from
e555105 to
64f340f
Compare
PiTrem
added a commit
that referenced
this pull request
Feb 27, 2026
PiTrem
added a commit
that referenced
this pull request
Feb 27, 2026
PiTrem
approved these changes
Mar 3, 2026
PiTrem
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Adds an info popover to the Inventory label input and improves error messaging.
Why: Users previously had no clear guidance about where to configure inventory labels and did not have an accessible navigation link to the docs.
Changes:
rather 1-story 1-commit than sub-atomic commits
commit title is meaningful => git history search
commit description is helpful => helps the reviewer to understand the changes
code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured
added code is linted
tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited
in case the changes are visible to the end-user, video or screenshots should be added to the PR => helps with user testing
testing coverage improvement is improved.
CHANGELOG : add a bullet point on top (optional: reference to github issue/PR )
parallele PR for documentation on docusaurus if the feature/fix is tagged for a release