Draft
Conversation
handles the openstats bug where multiple samples get combined into one output
- create MttAnalysisDetailsModal for viewing full analysis details - create MttResultsTable for displaying results in clean table format - create MttRequestStatusTable for request status display - improves code organization and reusability
- add deleteMttResult for deleting individual analysis results - add sendMttResultsToSample for batch sending results to samples - includes TODO notes for backend implementation
- replace renderDetailsModal with MttAnalysisDetailsModal component - replace renderRequestStatus with MttRequestStatusTable component - replace inline table rendering with MttResultsTable component - use mttDataProcessor utility for data transformation - remove repetitive inline styles in favor of bootstrap classes - clean up unused imports and variables
LCOV of commit
|
Move modal cleanup to finally block and reduce padding for compact results display
LCOV of commit
|
- Replace placeholder send-to-sample with working implementation using bulk_create_from_raw_data API. - Add proper success/error/partial notifications, include assay naming metadata (klass label, short label, element name), and improve selection toolbar UI. - Remove debug console logs from request fetching.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
LCOV of commit
|
LCOV of commit
|
LCOV of commit
|
LCOV of commit
|
LCOV of commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rather 1-story 1-commit than sub-atomic commits
commit title is meaningful => git history search
commit description is helpful => helps the reviewer to understand the changes
code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured
added code is linted
tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited
in case the changes are visible to the end-user, video or screenshots should be added to the PR => helps with user testing
testing coverage improvement is improved.
CHANGELOG : add a bullet point on top (optional: reference to github issue/PR )
parallele PR for documentation on docusaurus if the feature/fix is tagged for a release